mirror of
https://github.com/whyour/qinglong.git
synced 2026-09-23 20:15:19 +08:00
feat(ql3): add opaque cluster environment bundle delivery
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
// Remote Execution owns mounted Secret resolution for authenticated delivery.
|
||||
import {
|
||||
MAX_REMOTE_SECRET_DELIVERY_TOTAL_VALUE_BYTES,
|
||||
MAX_REMOTE_ENVIRONMENT_BUNDLE_VALUE_BYTES,
|
||||
MAX_REMOTE_SECRET_VALUE_BYTES,
|
||||
normalizeRemoteWorkerSecretDeliveryAuthority,
|
||||
type RemoteWorkerSecretDeliveryAuthority,
|
||||
@@ -82,7 +83,7 @@ export class ClusterMountedSecretProvider
|
||||
this.reader = new PrivateProjectedFileReader({
|
||||
rootDirectory: options.rootDirectory,
|
||||
minimumBytes: 0,
|
||||
maximumBytes: MAX_REMOTE_SECRET_VALUE_BYTES,
|
||||
maximumBytes: MAX_REMOTE_ENVIRONMENT_BUNDLE_VALUE_BYTES,
|
||||
access: 'private_material',
|
||||
});
|
||||
} catch (error) {
|
||||
@@ -116,6 +117,7 @@ export class ClusterMountedSecretProvider
|
||||
const buffers: Buffer[] = [];
|
||||
try {
|
||||
const values = [];
|
||||
const environmentBundles = [];
|
||||
let totalBytes = 0;
|
||||
for (const secretRef of normalized.secretRefs) {
|
||||
const bytes = await this.reader
|
||||
@@ -127,6 +129,9 @@ export class ClusterMountedSecretProvider
|
||||
);
|
||||
});
|
||||
buffers.push(bytes);
|
||||
if (bytes.byteLength > MAX_REMOTE_SECRET_VALUE_BYTES) {
|
||||
throw new ClusterMountedSecretProviderError('material_unavailable');
|
||||
}
|
||||
totalBytes += bytes.byteLength;
|
||||
if (totalBytes > MAX_REMOTE_SECRET_DELIVERY_TOTAL_VALUE_BYTES) {
|
||||
throw new ClusterMountedSecretProviderError('material_unavailable');
|
||||
@@ -138,9 +143,27 @@ export class ClusterMountedSecretProvider
|
||||
}),
|
||||
);
|
||||
}
|
||||
for (const secretRef of normalized.environmentBundleRefs) {
|
||||
const bytes = await this.reader
|
||||
.read(clusterMountedSecretFileName(secretRef))
|
||||
.catch((error) => {
|
||||
throw new ClusterMountedSecretProviderError(
|
||||
'material_unavailable',
|
||||
{ cause: error },
|
||||
);
|
||||
});
|
||||
buffers.push(bytes);
|
||||
environmentBundles.push(
|
||||
Object.freeze({
|
||||
secretRef,
|
||||
value: secretValue(bytes),
|
||||
}),
|
||||
);
|
||||
}
|
||||
let disposed = false;
|
||||
return Object.freeze({
|
||||
values: Object.freeze(values),
|
||||
environmentBundles: Object.freeze(environmentBundles),
|
||||
dispose() {
|
||||
if (disposed) return;
|
||||
disposed = true;
|
||||
|
||||
+11
-3
@@ -66,7 +66,9 @@ export class ClusterRemoteWorkerSecretDeliveryService {
|
||||
authorized.offerId !== command.offerId ||
|
||||
authorized.leaseGeneration !== command.leaseGeneration ||
|
||||
authorized.leaseVersion !== command.expectedLeaseVersion ||
|
||||
JSON.stringify(authorized.secretRefs) !== JSON.stringify(command.secretRefs)
|
||||
JSON.stringify(authorized.secretRefs) !== JSON.stringify(command.secretRefs) ||
|
||||
JSON.stringify(authorized.environmentBundleRefs) !==
|
||||
JSON.stringify(command.environmentBundleRefs)
|
||||
) throw new InvalidRemoteWorkerSecretDeliveryError(
|
||||
'repository authority does not match command',
|
||||
);
|
||||
@@ -88,7 +90,8 @@ export class ClusterRemoteWorkerSecretDeliveryService {
|
||||
if (
|
||||
typeof resolution !== 'object' ||
|
||||
Array.isArray(resolution) ||
|
||||
Object.keys(resolution).some((key) => key !== 'values' && key !== 'dispose') ||
|
||||
Object.keys(resolution).some((key) =>
|
||||
key !== 'values' && key !== 'environmentBundles' && key !== 'dispose') ||
|
||||
(resolution.dispose !== undefined &&
|
||||
typeof resolution.dispose !== 'function')
|
||||
) throw new InvalidRemoteWorkerSecretDeliveryError(
|
||||
@@ -100,13 +103,18 @@ export class ClusterRemoteWorkerSecretDeliveryService {
|
||||
offerId: authorized.offerId,
|
||||
executionDigest: authorized.executionDigest,
|
||||
values: resolution.values,
|
||||
}, authorized.secretRefs);
|
||||
environmentBundles: resolution.environmentBundles,
|
||||
}, {
|
||||
secretRefs: authorized.secretRefs,
|
||||
environmentBundleRefs: authorized.environmentBundleRefs,
|
||||
});
|
||||
return Object.freeze({
|
||||
runId: body.runId,
|
||||
attemptId: body.attemptId,
|
||||
offerId: body.offerId,
|
||||
executionDigest: body.executionDigest,
|
||||
values: body.values,
|
||||
environmentBundles: body.environmentBundles,
|
||||
...(resolution.dispose === undefined
|
||||
? {}
|
||||
: { dispose: resolution.dispose }),
|
||||
|
||||
@@ -519,9 +519,9 @@ export function loadClusterWorkerIngressConfig(
|
||||
maxResponseBytes: integerValue(
|
||||
environment,
|
||||
'QL3_WORKER_INGRESS_MAX_RESPONSE_BYTES',
|
||||
64 * 1024,
|
||||
256 * 1024,
|
||||
1024,
|
||||
64 * 1024,
|
||||
256 * 1024,
|
||||
),
|
||||
maxInFlightRequests: integerValue(
|
||||
environment,
|
||||
|
||||
@@ -465,7 +465,7 @@ export function createWorkerIngressAdmissionPipeline(
|
||||
'schema', 'runId', 'attemptId', 'projectId', 'taskId',
|
||||
'taskRevision', 'executionDigest', 'workerGeneration',
|
||||
'offerId', 'leaseGeneration', 'leaseToken',
|
||||
'expectedLeaseVersion', 'secretRefs',
|
||||
'expectedLeaseVersion', 'secretRefs', 'environmentBundleRefs',
|
||||
]);
|
||||
if (value.schema !== REMOTE_SECRET_DELIVERY_SCHEMA) {
|
||||
throw failure(400, 'invalid_worker_request');
|
||||
@@ -486,12 +486,16 @@ export function createWorkerIngressAdmissionPipeline(
|
||||
leaseToken: value.leaseToken as string,
|
||||
expectedLeaseVersion: value.expectedLeaseVersion as number,
|
||||
secretRefs: value.secretRefs as string[],
|
||||
environmentBundleRefs: value.environmentBundleRefs as string[],
|
||||
},
|
||||
);
|
||||
try {
|
||||
const responseBody = createRemoteWorkerSecretDeliveryResponseBody(
|
||||
delivered,
|
||||
value.secretRefs as string[],
|
||||
{
|
||||
secretRefs: value.secretRefs as string[],
|
||||
environmentBundleRefs: value.environmentBundleRefs as string[],
|
||||
},
|
||||
);
|
||||
if (
|
||||
responseBody.runId !== value.runId ||
|
||||
|
||||
Reference in New Issue
Block a user