From ce1a68871a9c2071a7ccc04f3961886ded3d69aa Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 25 Apr 2026 06:52:03 +0000
Subject: [PATCH] Address code review: use transactions for label updates, fix
 variable naming

Agent-Logs-Url: https://github.com/whyour/qinglong/sessions/1436272f-a03a-45af-b57d-869a48ab537d

Co-authored-by: whyour <22700758+whyour@users.noreply.github.com>
---
 back/services/env.ts    | 32 ++++++++++++++++++--------------
 src/pages/env/index.tsx |  2 +-
 2 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/back/services/env.ts b/back/services/env.ts
index 98fcfbea..d776aeb7 100644
--- a/back/services/env.ts
+++ b/back/services/env.ts
@@ -201,25 +201,29 @@ export default class EnvService {
 
   public async addLabels(ids: number[], labels: string[]) {
     const docs = await EnvModel.findAll({ where: { id: ids } });
-    for (const doc of docs) {
-      const env = doc.get({ plain: true });
-      await EnvModel.update(
-        { labels: Array.from(new Set((env.labels || []).concat(labels))) },
-        { where: { id: env.id } },
-      );
-    }
+    await sequelize.transaction(async (t) => {
+      for (const doc of docs) {
+        const env = doc.get({ plain: true });
+        await EnvModel.update(
+          { labels: Array.from(new Set((env.labels || []).concat(labels))) },
+          { where: { id: env.id }, transaction: t },
+        );
+      }
+    });
     return await EnvModel.findAll({ where: { id: ids } });
   }
 
   public async removeLabels(ids: number[], labels: string[]) {
     const docs = await EnvModel.findAll({ where: { id: ids } });
-    for (const doc of docs) {
-      const env = doc.get({ plain: true });
-      await EnvModel.update(
-        { labels: (env.labels || []).filter((label: string) => !labels.includes(label)) },
-        { where: { id: env.id } },
-      );
-    }
+    await sequelize.transaction(async (t) => {
+      for (const doc of docs) {
+        const env = doc.get({ plain: true });
+        await EnvModel.update(
+          { labels: (env.labels || []).filter((label: string) => !labels.includes(label)) },
+          { where: { id: env.id }, transaction: t },
+        );
+      }
+    });
     return await EnvModel.findAll({ where: { id: ids } });
   }
 
diff --git a/src/pages/env/index.tsx b/src/pages/env/index.tsx
index 4f1a9cb9..89a78015 100644
--- a/src/pages/env/index.tsx
+++ b/src/pages/env/index.tsx
@@ -128,7 +128,7 @@ const Env = () => {
       render: (labels: string[], record: any) => {
         return (
           <Space size={[0, 4]} wrap>
-            {labels?.filter((l) => l).map((label) => (
+            {labels?.filter((label) => label).map((label) => (
               <Tag key={label} color="blue">
                 {label}
               </Tag>